Skip to content

Commit

Permalink
typos in comments
Browse files Browse the repository at this point in the history
  • Loading branch information
annakrystalli committed Dec 20, 2023
1 parent 51260a9 commit 474f8b6
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions R/validate_pr.R
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ inform_unvalidated_files <- function(pr_df) {
)
}
# Checks for model output file modifications and model output & model metadata
# file deletions. Returns an <error/check_error>⁠ condition class object if any
# file deletions/renaming. Returns an <error/check_error>⁠ condition class object if any
# modification or deletion detected.
check_pr_modf_del_files <- function(pr_df, file_type = c(
"model_output",
Expand All @@ -214,8 +214,9 @@ check_pr_modf_del_files <- function(pr_df, file_type = c(
file_type <- rlang::arg_match(file_type)
alert <- rlang::arg_match(alert)

# subset pr_df to the file type beiing checked. We check model output and model
# metadata files separately as model metadata files are only check for deletions.
# subset pr_df to the file type being checked. We check model output and model
# metadata files separately as model metadata files are only checked for
# deletions/renaming.
# Also, they have no submission window so deletions are not affected by
# allow_submit_window_mods
df <- pr_df[pr_df[[file_type]], ]
Expand All @@ -229,7 +230,7 @@ check_pr_modf_del_files <- function(pr_df, file_type = c(
return(new_hub_validations())
}
# Check whether modifications allowed and return notification object according
# to alert for any file that violates allowed mod/del.
# to alert for any file that violates allowed mod/del rules.
out <- purrr::map(
.x = 1:nrow(df),
~ check_pr_modf_del_file(
Expand Down

0 comments on commit 474f8b6

Please sign in to comment.