Enhancement/handle null taskids #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 87.36% 87.23% -0.13%
==========================================
Files 20 20
Lines 1638 1637 -1
==========================================
- Hits 1431 1428 -3
- Misses 207 209 +2 ☔ View full report in Codecov by Sentry. |
micokoch
approved these changes
Mar 28, 2024
LucieContamin
approved these changes
Mar 28, 2024
This was
linked to
issues
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows task ID
create_task_id()argumentsrequiredandoptionalto both be set toNULL, facilitating the encoding ofNAtask IDs in modeling tasks where no value is expected for a given task ID.Also fixes broken links
Resolves issues:
create_task_id()for horizon returns an error if required and optional set to NULL #4requiredandoptionalare null #10