Update workflows to be fully re-useable #10
Merged
+79
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7073094.
See the note from https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#operators - GitHub ignores case when comparing strings. - steps.<step_id>.outputs.<output_name> evaluates as a string. You need to use specific syntax to tell GitHub to evaluate an expression rather than treat it as a string. For more information, see Accessing contextual information about workflow runs. - For numerical comparison, the fromJSON() function can be used to convert a string to a number. For more information on the fromJSON() function, see fromJSON.
[skip ci]
zkamvar
commented
Dec 20, 2024
zkamvar
commented
Dec 20, 2024
regenerate will already be in the correct format, so this is a good fallback.
zkamvar
commented
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the feedback in reichlab/decisions#5 and from many discussions with @elray, I have modified these workflows to be fully compatible as re-usable workflows without the need for an app.
I have created an example of these workflows in practice in https://github.com/zkamvar/hub-dashboard-workflow:
I'm also going to make a squash commit for this because there was a lot of trial and error.
NOTE: when this gets merged, I need to remove the
znk/no-tokenbranch from the caller workflows