Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

挂载持久化卷时，可以提前创建好对应目录，这样可以不依赖docker的自动创建目录的特性，避免权限问题 #203

Merged
merged 5 commits into from
Oct 24, 2023
Merged

挂载持久化卷时，可以提前创建好对应目录，这样可以不依赖docker的自动创建目录的特性，避免权限问题 #203

merged 5 commits into from
Oct 24, 2023

Conversation

etoyz
Copy link
Contributor

@etoyz etoyz commented Jul 20, 2023

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

huan
huan approved these changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan enabled auto-merge (squash) October 23, 2023 21:12
huan
huan requested changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the shellcheck warnings.

huan
huan reviewed Oct 23, 2023
View reviewed changes
dochat.sh Outdated Show resolved Hide resolved
auto-merge was automatically disabled October 24, 2023 03:06

Head branch was pushed to by a user without write access

etoyz

This comment was marked as duplicate.

Sign in to view

etoyz
etoyz commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@etoyz etoyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

huan
huan requested changes Oct 24, 2023
View reviewed changes
dochat.sh Outdated Show resolved Hide resolved
dochat.sh Outdated Show resolved Hide resolved
dochat.sh Outdated Show resolved Hide resolved
huan
huan previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan enabled auto-merge (squash) October 24, 2023 04:13
@huan
Copy link
Owner

huan commented Oct 24, 2023

Thank you very much for the improvements!

@huan
Copy link
Owner

huan commented Oct 24, 2023

Can you fix the failure in the CI?

After the CI passed this PR will be ready to be merged.

auto-merge was automatically disabled October 24, 2023 05:58

Head branch was pushed to by a user without write access

@etoyz
Copy link
Contributor Author

etoyz commented Oct 24, 2023

不好意思，我不太熟悉CI（： @huan

@etoyz etoyz requested a review from huan October 24, 2023 06:05
@huan huan enabled auto-merge (squash) October 24, 2023 09:21
huan
huan approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit de069de into huan:main Oct 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etoyz @CLAassistant @huan