Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python release action #227

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Fix Python release action #227

merged 2 commits into from
Dec 15, 2024

Conversation

TomBener
Copy link
Contributor

Problem

The Python release workflow was failing due to artifact naming conflicts. Multiple jobs were trying to upload artifacts with the same name 'wheels', causing 409 Conflict errors. #206 (comment)

Solution

Modified the workflow to use unique artifact names for each job:

  • wheels-macos for macOS builds
  • wheels-windows-x64 and wheels-windows-x86 for Windows builds
  • wheels-linux-x86_64 and wheels-linux-i686 for Linux builds
  • wheels-linux-cross-* for Linux cross-compilation builds
  • wheels-musllinux-* for musl Linux builds

Testing

Successfully tested with tag v2.13.0-test. All build jobs completed successfully:
https://github.com/TomBener/autocorrect/actions/runs/12336470865

The only expected failure was in the publish step due to missing PyPI credentials, which is normal for PR testing.

Changes

  • Updated artifact names in all jobs to be unique
  • Configured the publish job to download all artifacts using pattern matching
  • Maintained all other workflow functionality unchanged

Thanks for creating this great tool. Please feel free to edit this change.

@huacnlee
Copy link
Owner

huacnlee commented Dec 15, 2024

Do you have complete CI link? I need to check out if it passed.

@TomBener
Copy link
Contributor Author

Do you have complete CI link? I need to check out if it passed.

Do you mean this one: https://github.com/TomBener/autocorrect/actions

@huacnlee huacnlee merged commit d6f1c88 into huacnlee:main Dec 15, 2024
6 checks passed
@huacnlee
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants