Change hard-coded headernames to lowercase #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halvko
force-pushed
the
f-lowercase-header-names
branch
from
00970a1
to
d728868
Compare
yoshuawuyts
requested changes
Jan 25, 2022
There was a problem hiding this comment.
I'm not sure I understand what issue this solves? Header names should be case-agnostic. And since we're only ever encoding values here, if an error occurs it seems like the issue would be in a parser, not in any of the encoders?
I feel like I'm missing something?
|
As I understand it, headers are not case agnostic for HTTP/2 connections “However, header field names MUST be converted to lowercase prior to their encoding in HTTP/2” (https://httpwg.org/specs/rfc7540.html#HttpHeaders). |
|
And the documentation for ‘HeaderName::from_lowercase_str’ specifically states that the input is expected to be lowercase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change at line 114 in
src/security/mod.rscorrects a logic error, the rest is at best a small optimization and at worst a style choice