Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate: add features to switch Error backend #263

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fishrock123
Copy link
Member

Allows end users to choose between anyhow and eyre.

If using eyre, it is up to the application author to install an eyre reporter themselves.

This is an updated rebase of #215, with some notable changes:

  • No longer does an eyre reporter install.
  • Is all behind feature flags.

A concern: adding error_anyhow could break people using default-features = false.

@Fishrock123
Copy link
Member Author

Upon slightly further investigation - I think Tide may need to hook into this more manually in it's logger (or in any custom logger). More investigation is needed.

@Fishrock123 Fishrock123 marked this pull request as draft October 27, 2020 19:36
Allows end users to choose between anyhow and eyre.

Co-Authored-By: Jacob Rothstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant