Linux: add GPU meter and process column #1288

cgzones · 2023-08-29T11:35:39Z

Based on the DRM client usage stats1 add statistics for GPU time spend
and percentage utilization.

Tested with i915 and amdgpu.

BenBE · 2023-08-29T12:01:43Z

Does this recognize/work with multi-GPU setups?

BenBE

Using the fopen style API is hard to transform into liburing usage later on, thus try to avoid it. We also have a function xReadfile and xReadfileat to read a whole file at once into a appropriately sized buffer. For fdinfo files this should be sufficient and avoid the overhead of the fopen API.

linux/GPU.c

linux/GPU.h

linux/GPUMeter.h

linux/GPU.c

natoscott · 2023-08-30T06:20:57Z

linux/GPU.c

+          String_eq(ename, "0") ||
+          String_eq(ename, "1") ||
+          String_eq(ename, "2"))


Yeah - had the same thought, I think this little optimization is not always valid unfortunately (e.g. a program closes one of these three at some point, as happens in some daemons, and then they later get reused).

Explorer09 · 2023-08-31T17:09:47Z

I wish the autoTitleRightAlign flag be split to a separate PR. The reason is simply I don't like the current design of the flag, and I think it deserves more discussion before introducing it into the codebase.

linux/LinuxProcess.c

linux/GPU.c

linux/GPUMeter.c

BenBE · 2023-11-05T21:59:45Z

linux/GPUMeter.c

+static int humanTimeUnit(char* buffer, size_t size, unsigned long long int value) {
+
+   if (value < 1000)
+      return snprintf(buffer, size, "%3lluns", value);
+
+   value /= 1000;
+
+   if (value < 1000)
+      return snprintf(buffer, size, "%3lluus", value);
+
+   value /= 1000;
+
+   if (value < 1000)
+      return snprintf(buffer, size, "%3llums", value);
+
+   value /= 1000;
+
+   if (value < 600)
+      return snprintf(buffer, size, "%3llus", value);
+
+   value /= 60;
+
+   if (value < 600)
+      return snprintf(buffer, size, "%3llum", value);
+
+   value /= 60;
+
+   if (value < 96)
+      return snprintf(buffer, size, "%3lluh", value);
+
+   value /= 24;
+
+   return snprintf(buffer, size, "%3llud", value);
+}


Why not use xSnprintf?

I have some questions regarding this humanTimeUnit() function.

Is this meant for printing values in meters or data cells or both?

It seems that you are constraining the output to 5 characters (e.g. 999ns). Is this intentional?

Why are there 600s, 600m and 96h thresholds, in particular? As I rewrote the Row_printTime() function in PR Rewrite Row_printTime() with various improvements #1325, I start to think that such thresholds in humanTimeUnit() don't make sense.

As I had in the back of my mind, that there had been a PR regarding the time formatting code recently, I wrote that comment in #1321 so we can somehow focus these efforts.

For 600s and 600m the limits are kinda obvious with 10m and 10h respectively. For 96h (AKA 4d) the reason is likely to stay with whole days below a 3 digit value for hours.

I wonder why not format the time like 9.5m, 1h59m and 1d23h respectively. As I wrote #1325, I have an idea on how we can format the time within the 5 character limit.

0ns - 999ns 1.0us - 9.9us 10us - 999us 1.0ms - 999ms 1.0s - 59.9s 1m00s - 9m59s 10.0m - 59.9m 1h00m - 9h59m 10.0h - 23.9h 1d00h - 9d23h 10.0d - 99.9d 100d - 364d 1.0y - 99.9y 100y - 9999y inf - inf

With respect to #1317, I believe the format like 2h30m would be better than 150m.

Possible alternative, mostly re-uses the ranges from your proposal.

0ns - 999ns 1.0us - 9.9us 10us - 999us 1.0ms - 999ms 1.0s - 59.9s (Or 01.00 - 59.99 compared to the time column) 1:00 - 59:59 1h00 - 23h59 1d00h - 9d23h 10.0d - 99.9d 100d - 364d 1y00m - 9y11m 10.0y - 99.9y 100y - 9999y inf - inf

@BenBE No, the colon is ambiguous where there are hh:mm and mm:ss notations.
59m59 might be okay though.

The colon would be consistent with existing formatting though. Yes, 59m59 would work, but it's not the highest option on my list …

Used xSnprintf().

Added formatting for X.Y(us|ms|s).

The input values are difference values to the prior scan so they should be lower than the scan interval (1.5s).

linux/LinuxProcess.c

linux/LinuxProcessTable.c

The difference of scans is useful for utilization calculations. To avoid divisions by 0 on first scan set monotonicMs also on first scan.

Instead of handling PERCENT_CPU as a special case for whether to align the title of a dynamically sized column to the right or the left introduce a new flag, which can be reused by other columns.

Bail out early if the passed time is 0 and shadow the result.

Based on the DRM client usage stats[1] add statistics for GPU time spend and percentage utilization. [1]: https://www.kernel.org/doc/html/latest/gpu/drm-usage-stats.html

Instead of ignoring the standard file descriptors 0, 1 and 2 scan for GPU usage of a process only if that process had activity last cycle or its last scan was more than five seconds ago.

kryptobolt07 · 2024-06-29T10:27:13Z

The GPU meter doesn't seem to work on my intel haswell series processor(Intel Celeron 2955u),at least in the way i expect it to,the gpu utilizationn is displayed to be zero for example when browsing the web whereas using intel's own 'intel-gpu-tools' one can notice the render engines to be in active use.

cgzones force-pushed the linux_gpu branch 4 times, most recently from 53dc054 to 833420f Compare August 29, 2023 12:00

BenBE requested changes Aug 29, 2023

View reviewed changes

BenBE added Linux 🐧 Linux related issues new feature Completely new feature labels Aug 29, 2023

BenBE linked an issue Aug 29, 2023 that may be closed by this pull request

Add GPU utilization meter #406

Closed

Explorer09 reviewed Aug 29, 2023

View reviewed changes

linux/GPU.c Outdated Show resolved Hide resolved

Explorer09 reviewed Aug 29, 2023

View reviewed changes

linux/GPU.c Outdated Show resolved Hide resolved

Explorer09 reviewed Aug 29, 2023

View reviewed changes

linux/GPU.c Outdated Show resolved Hide resolved

Explorer09 reviewed Aug 29, 2023

View reviewed changes

linux/GPU.c Outdated Show resolved Hide resolved

natoscott requested changes Aug 30, 2023

View reviewed changes

cgzones force-pushed the linux_gpu branch 2 times, most recently from 9546934 to 44ec193 Compare September 3, 2023 19:47

cgzones mentioned this pull request Sep 3, 2023

Introduce autoTitleRightAlign column flag #1297

Closed

Explorer09 reviewed Sep 4, 2023

View reviewed changes

linux/LinuxProcess.c Outdated Show resolved Hide resolved

Explorer09 reviewed Sep 4, 2023

View reviewed changes

linux/GPU.c Outdated Show resolved Hide resolved

cgzones force-pushed the linux_gpu branch from 44ec193 to 2cc0e8c Compare November 5, 2023 17:02

BenBE reviewed Nov 5, 2023

View reviewed changes

BenBE mentioned this pull request Nov 9, 2023

Rewrite Row_printTime() with various improvements #1325

Merged

cgzones force-pushed the linux_gpu branch from 2cc0e8c to ce362dc Compare January 7, 2024 18:31

cgzones marked this pull request as ready for review January 9, 2024 21:12

cgzones added 4 commits January 9, 2024 22:14

Store time of the previous process scan

f82a6a2

The difference of scans is useful for utilization calculations. To avoid divisions by 0 on first scan set monotonicMs also on first scan.

Introduce autoTitleRightAlign column flag

02e3d0b

Instead of handling PERCENT_CPU as a special case for whether to align the title of a dynamically sized column to the right or the left introduce a new flag, which can be reused by other columns.

Introduce String_eq_nullable()

203979f

Short circuit zero time in Row_printTime()

56a76e3

Bail out early if the passed time is 0 and shadow the result.

cgzones force-pushed the linux_gpu branch from ce362dc to 8807efc Compare January 9, 2024 21:15

cgzones force-pushed the linux_gpu branch from 8807efc to fb33df5 Compare January 9, 2024 21:21

cgzones added 2 commits January 9, 2024 22:28

Linux: add GPU meter and process column

ed56d7d

Based on the DRM client usage stats[1] add statistics for GPU time spend and percentage utilization. [1]: https://www.kernel.org/doc/html/latest/gpu/drm-usage-stats.html

Linux: scan GPU based on previous activity

ef93964

Instead of ignoring the standard file descriptors 0, 1 and 2 scan for GPU usage of a process only if that process had activity last cycle or its last scan was more than five seconds ago.

cgzones force-pushed the linux_gpu branch from fb33df5 to ef93964 Compare January 9, 2024 21:28

cgzones requested a review from BenBE January 9, 2024 21:30

BenBE requested a review from natoscott January 9, 2024 23:19

cgzones merged commit 0318589 into htop-dev:main Mar 27, 2024
12 checks passed

cgzones deleted the linux_gpu branch March 27, 2024 18:49

BenBE added this to the 3.4.0 milestone Jun 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux: add GPU meter and process column #1288

Linux: add GPU meter and process column #1288

cgzones commented Aug 29, 2023

BenBE commented Aug 29, 2023

BenBE left a comment

natoscott Aug 30, 2023

Explorer09 commented Aug 31, 2023

BenBE Nov 5, 2023

Explorer09 Nov 9, 2023

BenBE Nov 9, 2023

Explorer09 Nov 9, 2023

BenBE Nov 9, 2023

Explorer09 Nov 9, 2023

BenBE Nov 9, 2023

cgzones Jan 9, 2024

kryptobolt07 commented Jun 29, 2024

Linux: add GPU meter and process column #1288

Linux: add GPU meter and process column #1288

Conversation

cgzones commented Aug 29, 2023

BenBE commented Aug 29, 2023

BenBE left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Explorer09 commented Aug 31, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kryptobolt07 commented Jun 29, 2024