Больше деталей #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photoDescription, similarWizards + script connection
bellavin
reviewed
Feb 26, 2024
js/main.js
Outdated
| 'Юлия', | ||
| 'Люпита', | ||
| 'Вашингтон', | ||
| // 8 |
There was a problem hiding this comment.
Здесь и далее нужно удалить комменты
js/main.js
Outdated
|
|
||
| const generatePhotoId = createRandomIdFromRangeGenerator(1, 25); | ||
| const generateId = createRandomIdFromRangeGenerator(1, OBJECT_COUNT); | ||
| const commentGenerateId = createRandomIdFromRangeGenerator(1, 9999); |
There was a problem hiding this comment.
Функции желательно именовать единообразно commentGenerateId -> generateCommentId
js/main.js
Outdated
| }); | ||
|
|
||
|
|
||
| const similarWizards = () => Array.from({ |
There was a problem hiding this comment.
У нас в проекте не будет волшебников. Надо придумать другое название переменной
js/main.js
Outdated
|
|
||
| const commentInformation = () => ({ | ||
| id: commentGenerateId(), | ||
| url: `img/avatar-${getRandomInteger(1, 6)}.svg`, |
There was a problem hiding this comment.
1 и 6 - магические числа. Надо вынести в переменную
Как вариант можно создать объект
const AVATAR_NUMBER = {
min: 1,
max: 6,
}
img/avatar-${getRandomInteger(AVATAR_NUMBER.min, AVATAR_NUMBER.max)}.svg
С остальными магическими числам надо поступить так же
js/main.js
Outdated
| }; | ||
| }; | ||
|
|
||
| const generatePhotoId = createRandomIdFromRangeGenerator(1, 25); |
There was a problem hiding this comment.
1 и 25 - магические числа
Ниже по коду такая же ситуация
-similarWizards -Функции-конструктор
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Больше деталей