-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module2 task1 #3
base: master
Are you sure you want to change the base?
Module2 task1 #3
Conversation
|
||
<body class="page__body"> | ||
<header class="main-header"> | ||
<a class="main-header_logo" href="index.html"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main-header_logo - два подчеркивания иначе это НЕ элемент)
Правильно main-header__logo
<div class="container catalog__container"> | ||
<ul class="catalog__list"> | ||
<li class="catalog__item product"> | ||
<a class="product__image-wrapper product__image-wrapper--item-1" href="#"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
product__image-wrapper--item-1 модификаторый от 1 до бесконечности бесполезны т.к. товаров может быть до 100тыс, и на это никто не будет писать css
<dl class="product__info"> | ||
<dt>Масса</dt> | ||
<dd>500 г</dd> | ||
<dt>Вкус</dt> | ||
<dd>Рыба</dd> | ||
<dt>Цена</dt> | ||
<dd>700 Р.</dd> | ||
</dl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Мне кажется лучше через table
будет намного удобнее
Это просто совет
<a class="product__button button" href="#">Заказать</a> | ||
</li> | ||
|
||
<li class="catalog__item catalog__item--add product product--add"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catalog__item--add product--add
Нужен 1модификатор, 2модификатор как то бессмысленно
<dl class="other__item-info"> | ||
<dt>1 упаковка (100 г)</dt> | ||
<dd>200 р.</dd> | ||
</dl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это не элемент списка)
здесь вполне сойдет тег p
<div class="contacts__wrapper"> | ||
<p class="contacts__text">Приглашаем <br> к сотрудничеству дилеров!</p> | ||
<p class="contacts__address">ул. Большая <br> Конюшенная, д. 19/8 <br> <span>Санкт-Петербург</span></p> | ||
<h2 class="visually-hidden">Карта</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
карту нужно поставить через ifraime (В тз про это описывают)
https://yandex.ru/q/question/kak_vstavit_iandeks_kartu_na_sait_c3a43120/
Как по примеру, обрати внимание ссылка предложит лишний код, тебе нужно будет добавить содержимое <iframe>
<header class="main-header"> | ||
<a class="main-header_logo" href="catalog.html"> | ||
<img class="main-header__logo-image" src="img/logotype-phone.svg" width="60" height="50" alt="CAT ENERGY"> | ||
</a>/.logo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.logo
слово написала
<li class="program__item program__item--pro"> | ||
<h3 class="program__item-title"> | ||
<span class="program__icon program__icon--pro"></span> | ||
Набор массы | ||
</h3> | ||
<p class="program__item-text program__item-text--pro"> | ||
Заработать авторитет среди дворовых котов и даже собак? Серия Cat Energy Pro поможет вашему коту нарастить необходимые мышцы! | ||
</p> | ||
<a class="program__item-button" href="catalog.html">Каталог Pro</a> | ||
</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можно не писать для каждого тега модификатор если не знаешь нужен ли он или нет
Это просто совет
No description provided.