Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka): set 'readerSetWaitOnlyWhenNoData' instead of set reader t… #1789

Closed
wants to merge 1 commit into from
Closed

fix(kafka): set 'readerSetWaitOnlyWhenNoData' instead of set reader t… #1789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions hstream-kafka/HStream/Kafka/Server/Handler/Consume.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ handleFetch sc@ServerContext{..} reqCtx r_ = K.catchFetchResponseEx $ do
x -> error $ "LogicError: this should not be " <> show x
pure $ K.FetchableTopicResponse topic (K.NonNullKaArray respPartitionDatas)
let resp = K.FetchResponse (K.NonNullKaArray respTopics) 0{- TODO: throttleTimeMs -}
Log.warning $ "Fetch request return error: " <> Log.build (show resp)
-- Exit early
throwIO $ K.FetchResponseEx resp

Expand Down Expand Up @@ -332,6 +333,7 @@ getPartitionLsn
-> Int64 -- ^ kafka start offset
-> IO LsnData
getPartitionLsn ldclient om logid partition offset = do
Log.debug $ "Request partition LSN for logid: " <> Log.build logid <> ", partition: " <> Log.build partition <> ", offset: " <> Log.build offset
m <- K.getLatestOffsetWithLsn om logid
case m of
Just (latestOffset, tailLsn) -> do
Expand All @@ -341,14 +343,16 @@ getPartitionLsn ldclient om logid partition offset = do
Log.debug1 $ "Try findKey " <> Log.buildString' key <> " in logid "
<> Log.build logid
(_, startLsn) <- S.findKey ldclient logid key S.FindKeyStrict
Log.debug1 $ "FindKey result " <> Log.build logid <> ": "
<> Log.build startLsn
Log.debug1 $ "FindKey for logid " <> Log.build logid <> " get result " <> Log.build startLsn
pure $ LsnData startLsn tailLsn highwaterOffset
| offset == latestOffset ->
| offset == latestOffset -> do
Log.debug1 $ "offset == latestOffset"
pure $ LsnData tailLsn tailLsn highwaterOffset
| offset == highwaterOffset ->
| offset == highwaterOffset -> do
Log.debug1 $ "offset == highwaterOffset"
pure $ LsnData (tailLsn + 1) tailLsn highwaterOffset
| offset > highwaterOffset ->
| offset > highwaterOffset -> do
Log.debug1 $ "offset > highwaterOffset"
pure $ ErrPartitionData $ errorPartitionResponse partition K.OFFSET_OUT_OF_RANGE
-- ghc is not smart enough to detact my partten matching is complete
| otherwise -> error "This should not be reached (getPartitionLsn)"
Expand Down Expand Up @@ -389,8 +393,9 @@ readMode1 r storageOpts reader = do

if r.minBytes <= 0 || r.maxWaitMs <= 0 -- respond immediately
then do
Log.debug1 $ "Set reader to nonblocking"
S.readerSetTimeout reader 0 -- nonblocking
Log.debug1 $ "Set reader wait only when no data and timeout to 10ms"
S.readerSetWaitOnlyWhenNoData reader
S.readerSetTimeout reader 10
insertRecords recordTable
-- For non-empty results
=<< S.readerReadSome reader storageOpts.fetchMaxLen 10{-retries-}
Expand Down
Loading