fix(kafka cpp): do not free NUL stable_ptr (#1747)

hstreamdb · Jan 23, 2024 · bcbee61 · bcbee61
1 parent d83cab5
commit bcbee61
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/hstream-kafka/cbits/hs_kafka_server.cpp b/hstream-kafka/cbits/hs_kafka_server.cpp
@@ -55,9 +55,12 @@ class ServerHandler : public HandlerAdapter<std::unique_ptr<folly::IOBuf>> {
   HsStablePtr sp_;
 
   void onClientExit() {
-    hs_free_stable_ptr(sp_);
-    // Make sure the haskell land does not use the freed stable pointer
-    sp_ = nullptr;
+    // FIXME: lock guard here?
+    if (sp_ != nullptr) {
+      hs_free_stable_ptr(sp_);
+      // Make sure the haskell land does not use the freed stable pointer
+      sp_ = nullptr;
+    }
   }
 };