-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoped listings #424
Draft
towerofnix
wants to merge
95
commits into
preview
Choose a base branch
from
scoped-listings
base: preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Scoped listings #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towerofnix
added
scope: repo structure & content
scope: data processing
scope: page generation - content
thing: listings
type: new feature
type: code cleanup
type: groundworks
Changes are foundational to further issues & code work
labels
Feb 23, 2024
towerofnix
force-pushed
the
scoped-listings
branch
from
February 24, 2024 17:42
5eed5ce
to
a4ae6e7
Compare
Merged
towerofnix
force-pushed
the
scoped-listings
branch
2 times, most recently
from
June 7, 2024 19:30
70d260f
to
0e598ed
Compare
This is sort of a stub / proof of concept function. The contained logic may be refactored a bit more still!
This commit was just labelled "WIP" when we committed it in the end of february so it may or may not be working LOL
towerofnix
force-pushed
the
scoped-listings
branch
from
June 12, 2024 21:54
0e598ed
to
f157403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
scope: data processing
scope: page generation - content
scope: repo structure & content
thing: listings
type: code cleanup
type: groundworks
Changes are foundational to further issues & code work
type: new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ooh, exciting! This pull request is a WIP.
Development:
Details:
listingData
object, but order matters (listing indexes reflect it), and the codebase is structured like a tree for ease of editing and maintaining the desired order.scope
property controlling which of the wiki data the listing runs on - discussed below!target
explicitly, rather than implicitly computing it from the spec's directory.data
property, which is the standard entry point for getting stuff out of a listing. (Details ofdata
value TBD, but it's probably always analogous to a content function'squery
.)albumData
for example), and of course inherit from the mainListing
constructor too.