Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cover" and "semilarge" thumb sizes #245

Draft
wants to merge 6 commits into
base: preview
Choose a base branch
from
Draft

Conversation

towerofnix
Copy link
Member

@towerofnix towerofnix commented Aug 13, 2023

Development:

Both 600x600, but cover is square-cropping and semilarge is not. cover is intended for use in generateCoverArtwork of course (i.e. the main art image on album, track, flash pages and such). semilarge is a corresponding smaller "right-fit" available for the client-side large image preview.

The motivator for this change is that the 400x400 medium thumbs currently used for cover artworks result in mildly blurry upscaling on high-DPI displays in the wide layout, as well as on about 450–600px wide displays of even normal CSS-matches-display-pixel DPI in the thin layout.

A 400x400 image doesn't exactly look awful rendered at about 600x600, though, or even when upscaled to about 800x800 on high-DPI displays in the thin layout. From some unscientific sampling, 600x600 at quality 94 results in about 40% larger files than 400x400 at quality 95. That's a moderately large tradeoff for mobile and slower network access, and you can always opt in to getting the best-fit size on particular covers just by clicking and showing the client-side image preview.

I've left this as a draft, besides the uncertainty, because I want to investigate if it's possible to restrict loading higher resolution images to high-DPI devices purely in HTML (no JavaScript nonsense).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding 600x600 "cover" thumbnail
1 participant