Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nintendo Music URLs #638

Open
wants to merge 7 commits into
base: preview
Choose a base branch
from
Open

Nintendo Music URLs #638

wants to merge 7 commits into from

Conversation

PhantomRuby
Copy link
Contributor

Adds URLs to Nintendo Music on applicable songs.

  • minor fixes

@PhantomRuby
Copy link
Contributor Author

still need to add Pokemon, but that's gonna be quite the undertaking

@PhantomRuby PhantomRuby marked this pull request as ready for review December 18, 2024 21:27
leo60228
leo60228 requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@leo60228 leo60228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs all look correct otherwise

album/pokemon-scarlet-violet-super-music-collection.yaml Outdated Show resolved Hide resolved
album/pokemon-scarlet-violet-super-music-collection.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo60228 leo60228 leo60228 approved these changes

Assignees
No one assigned
Labels
scope: beyond what: URLs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhantomRuby @leo60228