Fix PictureSequenceInfoField sometimes showing no pictures #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, when switching between two pictures, where the first is part of a sequence, the the other pictures in the sequence are not shown when switching back to the first. The exact reason is unclear, however print debugging has shown that during switching, the correct array of pictures is displayed first, only to be replaced by an empty array shortly after. Since this commit fixes the issue by changing the fetchPolicy from 'cache-first' (default) to 'cache-and-network', the problem is likely related to Apollo's caching behavior.
rheaSPK
approved these changes
Oct 13, 2023
olschulz
approved these changes
Nov 28, 2023
MariusDoe
deleted the
625-picturesequenceinfofield-sometimes-shows-no-pictures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #625
Before, when switching between two pictures, where the first is part of a sequence, the the other pictures in the sequence are not shown when switching back to the first. The exact reason is unclear, however print debugging has shown that during switching, the correct array of pictures is displayed first, only to be replaced by an empty array shortly after. Since this commit fixes the issue by changing the
fetchPolicyfrom'cache-first'(default) to'cache-and-network', the problem is likely related to Apollo's caching behavior.