add flags to Makefile for Frontier and update README #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
adistomar
changed the title
adityaranjan
reviewed
Apr 9, 2024
README.md
Outdated
| ``` | ||
| ### Frontier | ||
| ```sh | ||
| module load PrgEnv-cray amd-mixed craype-accel-amd-gfx90a |
There was a problem hiding this comment.
do we want to load a specific version of ROCM here? the default is 5.3.0 which is a bit low maybe
adityaranjan
reviewed
Apr 9, 2024
Makefile
Outdated
|
|
||
| # frontier flags | ||
| INC = -L${ROCM_PATH}/lib -lamdhip64 | ||
| CFLAGS = -std=c++11 -D__HIP_ROCclr__ -D__HIP_ARCH_GFX90A__=1 --rocm-path=${ROCM_PATH} --offload-arch=gfx90a -x hip -DUSE_ROCM -DUSE_RCCL |
adityaranjan
reviewed
Apr 9, 2024
Makefile
Outdated
| # LDFLAGS = -L/global/common/software/nersc9/nccl/2.19.4/lib -lnccl | ||
|
|
||
| # frontier flags | ||
| INC = -L${ROCM_PATH}/lib -lamdhip64 |
There was a problem hiding this comment.
- Both of these should probably go to LDFLAGS.
- do we not want to add something like -I${ROCM_PATH}/include like we do for perlmutter
adityaranjan
reviewed
Apr 9, 2024
Makefile
Outdated
|
|
||
| # frontier flags | ||
| INC = -L${ROCM_PATH}/lib -lamdhip64 | ||
| CFLAGS = -std=c++11 -D__HIP_ROCclr__ -D__HIP_ARCH_GFX90A__=1 --rocm-path=${ROCM_PATH} --offload-arch=gfx90a -x hip -DUSE_ROCM -DUSE_RCCL |
There was a problem hiding this comment.
--rocm-path=${ROCM_PATH} is duplicated in LDFLAGS
adistomar
changed the title
adistomar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates README instructions for loading different modules based on which cluster you're running on