Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Entity Spans #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BorisPolonsky
Copy link

@BorisPolonsky BorisPolonsky commented Aug 26, 2019

Fix Incorrect Entity Spans

Brief

Fixed inconsistency in span definition between

  • entities located in the beginning of a sentence (fixed)
  • the rest that follows the definition of Rasa NLU JSON format (left as is).

Entities are specified with a start and an end value, which together make a python style range to apply to the string, e.g. in the example below, with text="show me chinese restaurants", then text[8:15] == 'chinese'.

Fixed incorrect spans of entities that located at the beginning of a sentence.
@howl-anderson
Copy link
Owner

@BorisPolonsky Thank you for your PR. I am sorry for the delay. I am recently very busy, I will take a close look as soon as possible. I will keep you informed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants