Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draggable and resizable chat overlay in full screen mode #790

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Argn0
Copy link
Contributor

@Argn0 Argn0 commented May 5, 2023

No description provided.

@howardchung
Copy link
Owner

This is pretty cool! Will review the code later, but tested it quickly on the deploy preview.

Quick comments:

  • I'd probably put the reset button as part of the overlay rather than an option in settings
  • Seems like I can't put the box anywhere without covering up the video partially, but idk if anything can be done about that
  • Maybe we should include the tabs so the user can also display video chat if they want?
  • In another issue I think I requested the ability to show both text and video chats at the same time--wondering if it makes sense to make that part of this feature since there's more real estate. But also maybe just a "de-tab" option that expands the right panel would be easier

@Argn0
Copy link
Contributor Author

Argn0 commented May 6, 2023

I'd probably put the reset button as part of the overlay rather than an option in settings

I've put the reset button in the settings in case the overlay is somehow "lost" and inaccessible. For example, if the user changes their monitor configuration or screen resolution.

Seems like I can't put the box anywhere without covering up the video partially, but idk if anything can be done about that

We could add a collapse button that collapses the overlay into a tiny box that expands when you click on it.

Maybe we should include the tabs so the user can also display video chat if they want?

This should be possible.

@Argn0
Copy link
Contributor Author

Argn0 commented May 6, 2023

  • made the overlay collapsible
  • now it displays the entire right bar

@howardchung
Copy link
Owner

I may revisit some of this code to try implementing #848 which is asking for something like this but I think for the video chat only (not the text chat).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants