Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally inherit from ApplicationController #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eelcoj
Copy link

@eelcoj eelcoj commented Dec 1, 2024

This is taken from a custom override I add to all my app's lib folders.

I prefer to inherit from ApplicationController (app/javascript/controller/application_controller.js or whatever is more common/best practice) instead of Controller. Similarly how you inherit from ApplicationController in a Rails app, and not ActionController::Base.

If ApplicationController is not present, fallback to current default.

Possibly quite specific/niche, but wanted to share regardless to see what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant