Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pagination after fetching submissions from odk central #1971

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

Sujanadh
Copy link
Contributor

@Sujanadh Sujanadh commented Dec 10, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Issues:

Describe this PR

This PR updates the submission-table endpoint. It now removes the pagination value while fetching submissions from odkcentral. After fetching filtered submissions, it applies pagination and returns data along with pagination info.

Screenshots

N/A

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh requested a review from spwoodcock December 10, 2024 07:23
@Sujanadh Sujanadh self-assigned this Dec 10, 2024
@github-actions github-actions bot added bug Something isn't working backend Related to backend code labels Dec 10, 2024
@spwoodcock spwoodcock merged commit 3201089 into development Dec 10, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/submission-pagination branch December 10, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants