add check for caller address

horuslabsio · Sep 2, 2024 · 5ab435a · 5ab435a
1 parent 445f57c
commit 5ab435a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/components/permissionable/permissionable.cairo b/src/components/permissionable/permissionable.cairo
@@ -51,6 +51,7 @@ pub mod PermissionableComponent {
     // *************************************************************************
     pub mod Errors {
         pub const INVALID_LENGTH: felt252 = 'Account: invalid length';
+        pub const UNAUTHORIZED: felt252 = 'Account: unauthorized';
     }
 
 
@@ -76,6 +77,8 @@ pub mod PermissionableComponent {
 
             let account_comp = get_dep_component!(@self, Account);
             let owner = account_comp.owner();
+            assert(owner == get_caller_address(), Errors::UNAUTHORIZED);
+
             let length = permissioned_addresses.len();
             let mut index: u32 = 0;
             while index < length {

diff --git a/src/components/presets/account_preset.cairo b/src/components/presets/account_preset.cairo
@@ -155,10 +155,6 @@ pub mod AccountPreset {
             permissioned_addresses: Array<ContractAddress>,
             permissions: Array<bool>
         ) {
-            // validate signer
-            let caller = get_caller_address();
-            assert(self.is_valid_signer(caller), 'Account: unauthorized');
-
             // set permissions
             self.permissionable.set_permission(permissioned_addresses, permissions)
         }