Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify workflows #661
Unify workflows #661
Changes from all commits
f6ae7ee
a3f0f32
2276760
54080f7
f4781e6
1cd559d
b407c63
12fcc30
3e8a3bb
8259b00
f7fb564
d3feda1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve PR version extraction for better security.
The current method of extracting the PR version could be improved to prevent potential command injection.
Consider using
jq
with the--raw-output
(-r
) option and proper quoting:This change ensures proper quoting and uses the full
--raw-output
option for clarity.Committable suggestion
Tools
actionlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Well-implemented release creation and Docker image push
The steps for creating a GitHub release and pushing a Docker image are well-structured and use appropriate actions.
The static analysis tool flagged a potential issue with quoting in the jq command. To address this, please update line 69 as follows:
This change ensures proper quoting and prevents potential issues with word splitting and globbing.
Tools
actionlint