Shorten error handling wrapper

This shortens pyodide.asm.js by about 5kb by reducing the space taken up by this unreachable macro-generated code
hoodmane · Sep 24, 2023 · 9116451 · 9116451
1 parent 13d5e0d
commit 9116451
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/error_handling.h b/src/core/error_handling.h
@@ -109,9 +109,7 @@ console_error_obj(JsRef obj);
         Module.handle_js_error(e);                                             \
         return 0;                                                              \
     }                                                                          \
-    throw new Error(                                                           \
-      "Assertion error: control reached end of function without return"        \
-    );                                                                         \
+    errNoRet();                                                                \
   })
 
 #define EM_JS_NUM(ret, func_name, args, body...)                               \

diff --git a/src/core/pre.js b/src/core/pre.js
@@ -53,3 +53,5 @@ function hasMethod(obj, prop) {
 
 const pyproxyIsAlive = (px) => !!Module.PyProxy_getAttrsQuiet(px).shared.ptr;
 API.pyproxyIsAlive = pyproxyIsAlive;
+
+const errNoRet = () => {throw new Error("Assertion error: control reached end of function without return");};
Original file line number	Diff line number	Diff line change
Expand Up		@@ -53,3 +53,5 @@ function hasMethod(obj, prop) {

		const pyproxyIsAlive = (px) => !!Module.PyProxy_getAttrsQuiet(px).shared.ptr;
		API.pyproxyIsAlive = pyproxyIsAlive;

		const errNoRet = () => {throw new Error("Assertion error: control reached end of function without return");};