libheaptrace: Add dual sorted reporting feature #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add 'dual' option for sort feature 'dual' option will report size as well as count sorted results Usage example: $ heaptrace --sort dual a.out Signed-off-by: Bojun Seo <[email protected]>
|
Thanks for the PR, but I think printing both sort orders isn't related to |
honggyukim
added a commit
that referenced
this pull request
Jan 21, 2023
Bojun requested to make heaptrace support multiple sort keys because
sometimes it's useful to show the memory allocation status based on both
size and count orders.
If someone wants to show allocation status based on count and size, then
it can be requested as follows.
$ heaptrace -s size,count <target program>
The sort orders can be separated by commas(',').
Another small change is that it removes heap traced allocation size.
Closes: #9, #11
Signed-off-by: Honggyu Kim <[email protected]>
|
I've merged the patches I mentioned at #9 so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dualoption for sort featuredualoption will reportsizeas well ascountsorted results.Usage example:
This PR is to resolve following issue.
#9
In fact, I'm reluctant on this patch.
First, the code is clean but not readable(in my opinion).
Second, the report is not kind to user.