Fix Import Error for Androguard >=4 and Update setup.py Entry Points due to the possible error #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Entry Points due to the possible error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, the latest Androguard version is >= 4 and it has made some API changes. But droidbot didn't set the fixed version of Androguard. So when users install the latest Androguard, they may get some import error.
Changes:
Fix Import Error:
The import statement for the APK class has been updated to ensure compatibility with androguard version 4 and above. The new code attempts to import from two possible locations, handling the potential ImportError gracefully.
Update setup.py Entry Points:
The entry_points in the setup.py file have been modified to correctly reference the droidbot.start:main function. This ensures that the droidbot command works as expected when installed. This change will fix ModuleNotFoundError: No module named 'start' #157