-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EN] Improve light_HassLightSet sentences #1784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
Co-authored-by: Tudor Sandu <[email protected]>
@joshuayuen99 how do you feel about this? |
Can you please update the branch? If all tests go well after that, we'll merge it |
Updated! |
Thank you @joshuayuen99 |
* Improve light_HassLightSet sentences * Update sentences/en/light_HassLightSet.yaml Co-authored-by: Tudor Sandu <[email protected]> * Add "of" to <in> expansion rule --------- Co-authored-by: Tudor Sandu <[email protected]>
No description provided.