Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EN] Improve light_HassLightSet sentences #1784

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

joshuayuen99
Copy link
Contributor

No description provided.

@joshuayuen99 joshuayuen99 requested a review from tetele as a code owner December 14, 2023 06:42
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joshuayuen99

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Contributor

@tetele tetele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

sentences/en/light_HassLightSet.yaml Outdated Show resolved Hide resolved
@tetele
Copy link
Contributor

tetele commented Dec 14, 2023

@joshuayuen99 how do you feel about this?

@tetele tetele marked this pull request as ready for review December 14, 2023 21:15
@home-assistant home-assistant bot requested a review from tetele December 14, 2023 21:15
@tetele
Copy link
Contributor

tetele commented Dec 14, 2023

Can you please update the branch? If all tests go well after that, we'll merge it

@joshuayuen99
Copy link
Contributor Author

Can you please update the branch? If all tests go well after that, we'll merge it

Updated!

@tetele tetele merged commit 827b82a into home-assistant:main Dec 14, 2023
2 checks passed
@tetele
Copy link
Contributor

tetele commented Dec 14, 2023

Thank you @joshuayuen99

schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
* Improve light_HassLightSet sentences

* Update sentences/en/light_HassLightSet.yaml

Co-authored-by: Tudor Sandu <[email protected]>

* Add "of" to <in> expansion rule

---------

Co-authored-by: Tudor Sandu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants