Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pywaze to 0.4.0 #99995

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Bump pywaze to 0.4.0 #99995

merged 1 commit into from
Sep 9, 2023

Conversation

eifinger
Copy link
Contributor

@eifinger eifinger commented Sep 9, 2023

Proposed change

Release 0.4.0 wraps httpx.TimeoutExceptions into the custom WRCError which is already caught here:

.

This prevents stack traces as reported in this issue and allows to ignore the error messages.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek joostlek changed the title bump pywaze from 0.3.0 to 0.4.0 for waze_travel_time Bump pywaze to 0.4.0 Sep 9, 2023
@bdraco bdraco added this to the 2023.9.2 milestone Sep 9, 2023
@joostlek joostlek merged commit 862506a into home-assistant:dev Sep 9, 2023
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants