Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the elevation in set_location #99978

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

jrieger
Copy link
Contributor

@jrieger jrieger commented Sep 9, 2023

Proposed change

Allow setting the elevation in set_location as requested in #24328 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 9, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jrieger jrieger force-pushed the set_location_elevation branch from 55d2502 to 44b6094 Compare September 9, 2023 13:32
@home-assistant
Copy link

home-assistant bot commented Sep 9, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 9, 2023 14:22
@jrieger jrieger marked this pull request as ready for review September 9, 2023 15:13
@home-assistant home-assistant bot marked this pull request as draft September 9, 2023 15:29
@jrieger jrieger marked this pull request as ready for review September 9, 2023 15:42
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small test improvement :)

tests/components/homeassistant/test_init.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 12, 2023 12:27
@jrieger jrieger marked this pull request as ready for review September 12, 2023 14:41
@home-assistant home-assistant bot requested a review from edenhaus September 12, 2023 14:41
homeassistant/components/homeassistant/__init__.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 12, 2023 14:44
@jrieger jrieger marked this pull request as ready for review September 12, 2023 14:49
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a PR to update the docs

@jrieger
Copy link
Contributor Author

jrieger commented Sep 13, 2023

Done, see home-assistant/home-assistant.io#28900

@jrieger jrieger marked this pull request as ready for review September 13, 2023 15:49
@home-assistant home-assistant bot requested a review from edenhaus September 13, 2023 15:49
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrieger 👍

@edenhaus edenhaus merged commit ee65aa9 into home-assistant:dev Sep 13, 2023
31 checks passed
@jrieger jrieger deleted the set_location_elevation branch September 14, 2023 05:04
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants