Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught Blink exceptions #69770

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Fix uncaught Blink exceptions #69770

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f18721
Add try/except around image extraction in case broken or incomplete data
fronzbot Apr 9, 2022
171aba3
Swap info log writes with debug
fronzbot Apr 9, 2022
74f38d7
Replaced empty byte string with None
fronzbot Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion homeassistant/components/blink/camera.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

import logging

from requests.exceptions import ChunkedEncodingError

from homeassistant.components.camera import Camera
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
Expand Down Expand Up @@ -85,4 +87,11 @@ def camera_image(
self, width: int | None = None, height: int | None = None
) -> bytes | None:
"""Return a still image response from the camera."""
return self._camera.image_from_cache.content
try:
return self._camera.image_from_cache.content
except ChunkedEncodingError:
_LOGGER.debug("Could not retrieve image for %s", self._camera.name)
return None
except TypeError:
_LOGGER.debug("No cached image for %s", self._camera.name)
return None