Add discovery support to synology_dsm

[bdraco]

Breaking change

The name configuration key has been removed.

Proposed change

Add discovery support to synology_dsm

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Remove name configuration key from synology_dsm as it is no longer used home-assistant.io#12729

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @ProtoThis, @Quentame, mind taking a look at this pull request as its been labeled with a integration (synology_dsm) you are listed as a codeowner for? Thanks!

[bdraco]

@Quentame I figure since you did all the hard work, I could do this.

[Quentame]

@Quentame I figure since you did all the hard work, I could do this.

Hahaha, thanks !
I am self isolated at parent's house, so couldn't do discovery either at the moment (or maybe with some kind of VPN/SSH tunnel tricks, I don't know).

Will look at it in few hours.

[bdraco]

@Quentame It looks like

self._api.temp_unit is called but I can't find it in the library

[Quentame]

@Quentame It looks like

self._api.temp_unit is called but I can't find it in the library

Indeed, I thought I introduced a bug in 0.5.0 but no, this was like this before ... we should intestigate more but maybe we can remove this code.

[Quentame]

Added "breaking change" + "docs-missing" because of CONF_NAME removal.

[bdraco]

@Quentame It looks like
self._api.temp_unit is called but I can't find it in the library

Indeed, I thought I introduced a bug in 0.5.0 but no, this was like this before ... we should intestigate more but maybe we can remove this code.

I'll dig into this more later tonight and see what needs to change since its in a few places

[bdraco]

@Quentame Its correct

temp_unit is a property of class SynoApi not class SynologyDSM.api

Naming is hard!

[Quentame]

Tests are good for the non discovery part (can't test discovery).

Tested with:

• UI
• config.yaml basic
• config.yaml basic + disks + volumes

[Quentame]

@bdraco, maybe you can clean your repo 😂

[Quentame]

Py test also passing

[MartinHjelmare]

Please rebase on latest dev branch to let the build pass. We've merged a fix for the pylint issue.