Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow update entities to report progress as a float #128930

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Allow update entities to report progress as a float #128930

merged 5 commits into from
Oct 24, 2024

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Oct 21, 2024 •
edited
Loading

Proposed change

Allow update entities to report progress as a float

This implements home-assistant/architecture#1157

Frontend PR: home-assistant/frontend#22470

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner October 21, 2024 18:20
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (update) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of update can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign update Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

MartinHjelmare
MartinHjelmare requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a test that uses a float for progress together with the display precision. Also other tests need updating.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 21, 2024 20:10
@emontnemery emontnemery marked this pull request as ready for review October 22, 2024 06:01
@emontnemery emontnemery mentioned this pull request Oct 22, 2024
Draft
5 tasks
@emontnemery emontnemery mentioned this pull request Oct 22, 2024
Merged
9 tasks
@MartinHjelmare MartinHjelmare marked this pull request as draft October 24, 2024 09:39
@emontnemery emontnemery marked this pull request as ready for review October 24, 2024 17:02
@emontnemery emontnemery merged commit bd55fe8 into dev Oct 24, 2024
46 checks passed
@emontnemery emontnemery deleted the update_entity_update_percentage_float branch October 24, 2024 19:20
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Oct 25, 2024
@emontnemery @zxdavb
Allow update entities to report progress as a float (home-assistant#1…
7a3b927 
…28930)

* Allow update entities to report progress as a float

* Add test

* Update snapshots

* Update recorder test

* Use _attr_* in MockUpdateEntity
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kane610 Kane610 Awaiting requested review from Kane610 Kane610 is a code owner

@mib1185 mib1185 Awaiting requested review from mib1185 mib1185 is a code owner

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

@joostlek joostlek Awaiting requested review from joostlek joostlek is a code owner

@MartinHjelmare MartinHjelmare Awaiting requested review from MartinHjelmare

Assignees
No one assigned
Labels
by-code-owner cla-signed core Hacktoberfest has-tests integration: update new-feature Quality Scale: internal small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emontnemery @MartinHjelmare