Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Owon PC321 Z sensors to ZHA #100735

Closed
wants to merge 2 commits into from
Closed

Conversation

exelsis423
Copy link

@exelsis423 exelsis423 commented Sep 22, 2023

Breaking change

Proposed change

Following a creation of a new quirk for the PC321 Z metering, creating new sensors to be able to use it.

Type of change

New sensors creation.

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [x ] The code change is tested and works locally.
  • [x ] Local tests pass. Your PR cannot be merged unless tests pass
  • [x ] There is no commented out code in this PR.
  • [x ] I have followed the development checklist
  • [x ] I have followed the perfect PR recommendations
  • [x ] The code has been formatted using Black (black --fast homeassistant tests)
  • [x ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi @exelsis423

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery emontnemery changed the title Creating new sensor to use properly new Owon PC321 Z quirk Add Owon PC321 Z sensors to ZHA Sep 27, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked PR is not merged: zigpy/zha-device-handlers#2602

Also, I think this PR needs to include a dependency bump to a new version of zigpy once the linked PR is merged and included in a release?

@home-assistant home-assistant bot marked this pull request as draft September 27, 2023 12:34
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Removed old ep_attribute to use smartenergy_metering
@exelsis423
Copy link
Author

Actually you're right, the linked PR is in progress.
And when reviewing it I made new changes in this sensor.py.

Let me wait the other PR to be closed, and then I will come back on this one.

Regarding including a dependency bump, how do I will have to proceed?

Thanks !!

@frenck
Copy link
Member

frenck commented Oct 9, 2023

I'm going to close this PR for now, as this PR is not actionable at this point.

Do not submit new pull requests that depend on other pull requests that are still open/unmerged. This will create unneeded pull requests in the queue that are not actionable.

From our pull request review process documentation: https://developers.home-assistant.io/docs/review-process/

Feel free to re-open when it becomes available.

../Frenck

@frenck frenck closed this Oct 9, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants