-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Owon PC321 Z sensors to ZHA #100735
Add Owon PC321 Z sensors to ZHA #100735
Conversation
Hi @exelsis423 It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linked PR is not merged: zigpy/zha-device-handlers#2602
Also, I think this PR needs to include a dependency bump to a new version of zigpy once the linked PR is merged and included in a release?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Removed old ep_attribute to use smartenergy_metering
Actually you're right, the linked PR is in progress. Let me wait the other PR to be closed, and then I will come back on this one. Regarding including a dependency bump, how do I will have to proceed? Thanks !! |
I'm going to close this PR for now, as this PR is not actionable at this point.
From our pull request review process documentation: https://developers.home-assistant.io/docs/review-process/ Feel free to re-open when it becomes available. ../Frenck |
Breaking change
Proposed change
Following a creation of a new quirk for the PC321 Z metering, creating new sensors to be able to use it.
Type of change
New sensors creation.
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: