Skip to content

Commit

Permalink
Move uptimerobot coordinator to its own file (#100558)
Browse files Browse the repository at this point in the history
* Move uptimerobot coordinator to its own file

* Fix import of coordinator in platforms
  • Loading branch information
jpbede authored Sep 19, 2023
1 parent 2722e5d commit cf6edde
Show file tree
Hide file tree
Showing 6 changed files with 85 additions and 73 deletions.
72 changes: 3 additions & 69 deletions homeassistant/components/uptimerobot/__init__.py
Original file line number Diff line number Diff line change
@@ -1,22 +1,17 @@
"""The UptimeRobot integration."""
from __future__ import annotations

from pyuptimerobot import (
UptimeRobot,
UptimeRobotAuthenticationException,
UptimeRobotException,
UptimeRobotMonitor,
)
from pyuptimerobot import UptimeRobot

from homeassistant.config_entries import ConfigEntry
from homeassistant.const import CONF_API_KEY
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import ConfigEntryAuthFailed
from homeassistant.helpers import device_registry as dr
from homeassistant.helpers.aiohttp_client import async_get_clientsession
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed

from .const import API_ATTR_OK, COORDINATOR_UPDATE_INTERVAL, DOMAIN, LOGGER, PLATFORMS
from .const import DOMAIN, PLATFORMS
from .coordinator import UptimeRobotDataUpdateCoordinator


async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
Expand Down Expand Up @@ -51,64 +46,3 @@ async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
hass.data[DOMAIN].pop(entry.entry_id)

return unload_ok


class UptimeRobotDataUpdateCoordinator(DataUpdateCoordinator[list[UptimeRobotMonitor]]):
"""Data update coordinator for UptimeRobot."""

config_entry: ConfigEntry

def __init__(
self,
hass: HomeAssistant,
config_entry_id: str,
dev_reg: dr.DeviceRegistry,
api: UptimeRobot,
) -> None:
"""Initialize coordinator."""
super().__init__(
hass,
LOGGER,
name=DOMAIN,
update_interval=COORDINATOR_UPDATE_INTERVAL,
)
self._config_entry_id = config_entry_id
self._device_registry = dev_reg
self.api = api

async def _async_update_data(self) -> list[UptimeRobotMonitor]:
"""Update data."""
try:
response = await self.api.async_get_monitors()
except UptimeRobotAuthenticationException as exception:
raise ConfigEntryAuthFailed(exception) from exception
except UptimeRobotException as exception:
raise UpdateFailed(exception) from exception

if response.status != API_ATTR_OK:
raise UpdateFailed(response.error.message)

monitors: list[UptimeRobotMonitor] = response.data

current_monitors = {
list(device.identifiers)[0][1]
for device in dr.async_entries_for_config_entry(
self._device_registry, self._config_entry_id
)
}
new_monitors = {str(monitor.id) for monitor in monitors}
if stale_monitors := current_monitors - new_monitors:
for monitor_id in stale_monitors:
if device := self._device_registry.async_get_device(
identifiers={(DOMAIN, monitor_id)}
):
self._device_registry.async_remove_device(device.id)

# If there are new monitors, we should reload the config entry so we can
# create new devices and entities.
if self.data and new_monitors - {str(monitor.id) for monitor in self.data}:
self.hass.async_create_task(
self.hass.config_entries.async_reload(self._config_entry_id)
)

return monitors
2 changes: 1 addition & 1 deletion homeassistant/components/uptimerobot/binary_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback

from . import UptimeRobotDataUpdateCoordinator
from .const import DOMAIN
from .coordinator import UptimeRobotDataUpdateCoordinator
from .entity import UptimeRobotEntity


Expand Down
78 changes: 78 additions & 0 deletions homeassistant/components/uptimerobot/coordinator.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
"""DataUpdateCoordinator for the uptimerobot integration."""
from __future__ import annotations

from pyuptimerobot import (
UptimeRobot,
UptimeRobotAuthenticationException,
UptimeRobotException,
UptimeRobotMonitor,
)

from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant
from homeassistant.exceptions import ConfigEntryAuthFailed
from homeassistant.helpers import device_registry as dr
from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed

from .const import API_ATTR_OK, COORDINATOR_UPDATE_INTERVAL, DOMAIN, LOGGER


class UptimeRobotDataUpdateCoordinator(DataUpdateCoordinator[list[UptimeRobotMonitor]]):
"""Data update coordinator for UptimeRobot."""

config_entry: ConfigEntry

def __init__(
self,
hass: HomeAssistant,
config_entry_id: str,
dev_reg: dr.DeviceRegistry,
api: UptimeRobot,
) -> None:
"""Initialize coordinator."""
super().__init__(
hass,
LOGGER,
name=DOMAIN,
update_interval=COORDINATOR_UPDATE_INTERVAL,
)
self._config_entry_id = config_entry_id
self._device_registry = dev_reg
self.api = api

async def _async_update_data(self) -> list[UptimeRobotMonitor]:
"""Update data."""
try:
response = await self.api.async_get_monitors()
except UptimeRobotAuthenticationException as exception:
raise ConfigEntryAuthFailed(exception) from exception
except UptimeRobotException as exception:
raise UpdateFailed(exception) from exception

if response.status != API_ATTR_OK:
raise UpdateFailed(response.error.message)

monitors: list[UptimeRobotMonitor] = response.data

current_monitors = {
list(device.identifiers)[0][1]
for device in dr.async_entries_for_config_entry(
self._device_registry, self._config_entry_id
)
}
new_monitors = {str(monitor.id) for monitor in monitors}
if stale_monitors := current_monitors - new_monitors:
for monitor_id in stale_monitors:
if device := self._device_registry.async_get_device(
identifiers={(DOMAIN, monitor_id)}
):
self._device_registry.async_remove_device(device.id)

# If there are new monitors, we should reload the config entry so we can
# create new devices and entities.
if self.data and new_monitors - {str(monitor.id) for monitor in self.data}:
self.hass.async_create_task(
self.hass.config_entries.async_reload(self._config_entry_id)
)

return monitors
2 changes: 1 addition & 1 deletion homeassistant/components/uptimerobot/diagnostics.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant

from . import UptimeRobotDataUpdateCoordinator
from .const import DOMAIN
from .coordinator import UptimeRobotDataUpdateCoordinator


async def async_get_config_entry_diagnostics(
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/uptimerobot/sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback

from . import UptimeRobotDataUpdateCoordinator
from .const import DOMAIN
from .coordinator import UptimeRobotDataUpdateCoordinator
from .entity import UptimeRobotEntity


Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/uptimerobot/switch.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback

from . import UptimeRobotDataUpdateCoordinator
from .const import API_ATTR_OK, DOMAIN, LOGGER
from .coordinator import UptimeRobotDataUpdateCoordinator
from .entity import UptimeRobotEntity


Expand Down

0 comments on commit cf6edde

Please sign in to comment.