Intake-ifying osm #20
Conversation
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Note that the file isn't downloaded yet. The following step will take some time:" |
There was a problem hiding this comment.
How do you know at this point whether it's been downloaded yet? Won't it be cached? Seems like it should say instead that "Note that the first time this cell is executed, the file will take some time to download, but subsequent runs will skip that step".
| @@ -0,0 +1,6 @@ | |||
| sources: | |||
| osm_one_billion: | |||
| description: Test data points to same fake osm-3billion file | |||
There was a problem hiding this comment.
Same as what? Try to reword in a way that makes sense when reading just this one file.
|
There is a lingering issue here where the urlpath that is returned in https://github.com/intake/intake-parquet/blob/f029a36ba5c7a644b4faebd2a40d6ec21dbc5681/intake_parquet/source.py#L134 is actually a list of paths where the first one is the path to the parquet dir which is all that you actually need. This crops up when you run |
|
Closing this for now, although I won't delete the branch yet. |
This PR:
Blocked on intake/intake-parquet#11 and intake-parquet release.