19 - deposit money to bank account #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add balance column to account table
Add Money class to Account entity. Update tests with new type. Refactor: More end-lines to files
Add initial deposit and withdraw methods to domain layer and accountAdapter with some validations.
…e throwing npe. Refactor tests to support mockK Create useCase for deposit feature
Add custom exceptions for validations
Refactor inAdapter to be in single file Refactor Account out adapter. Add DepositAccount in port and moneyDeposited event.
# Conflicts: # demo-transactions/pom.xml # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/adapter/inbound/account/AccountRestInAdapter.kt # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/adapter/inbound/account/mapper/AccountDtoMapper.kt # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/adapter/outbound/account/jpa/AccountOutAdapter.kt # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/application/port/outbound/account/AccountOutPort.kt # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/application/usecase/CreateAccountUsecase.kt # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/domain/model/account/Account.kt # demo-transactions/src/main/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/domain/model/account/Money.kt # demo-transactions/src/main/resources/api/api.yaml # demo-transactions/src/test/kotlin/io/holixon/cqrshexagonaldemo/demoparent/transactions/application/usecase/CreateAccountUsecaseTest.kt
Remove withdraw feature doesn't belong on this development. Fix: Fix testing to support Amount value class Add mockk version to pom
…untOutPortAdapter. Remove unused test with the refactor.
…n api test: run integration tests on verify phase feat: add logging
mmiikkkkaa
reviewed
Apr 19, 2024
| private val eventingOutAdapter: EventingOutAdapter | ||
| ) : DepositAccountInPort { | ||
|
|
||
| override fun deposit(accountNumber: String, amount: Amount) { |
There was a problem hiding this comment.
There should already an Iban comming in, instead of an account number. Adapters/Infrastructure components should be the only ones, who use primitives/non-domain-objects.
.../cqrshexagonaldemo/demoparent/transactions/adapter/outbound/account/jpa/AccountOutAdapter.kt
Show resolved
Hide resolved
| @@ -72,6 +72,33 @@ paths: | |||
| application/json: | |||
| schema: | |||
| $ref: '#/components/schemas/AccountCreatedResponse' | |||
| /api/v1/account/deposit: | |||
| put: | |||
There was a problem hiding this comment.
put is not the correct rest method here, since put calls should be idempotent. But depositing money shouldn't be idempotent, since the result each time should be an increased balance.
There was a problem hiding this comment.
Yeah makes sense 🙈 since only deposit of 0 would be idempotent but it doesn't make sense to do it 😅 in the beginning i was using post request but since deposit was updating the entity it felt natural to use a put request i wasn't think of the idempotency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the features for Deposit money into an account.
Also more tests were added with some useCases to support not only the happy paths but also unhappy one's.