Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement customer and account creation #14

Merged
merged 10 commits into from
Apr 5, 2024

Conversation

mmiikkkkaa
Copy link
Contributor

No description provided.

@mmiikkkkaa mmiikkkkaa linked an issue Mar 8, 2024 that may be closed by this pull request
Copy link
Contributor

@janweinschenker janweinschenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the @Componentannotation can be removed and the event publisher could be wrappen in an adapter.

@rafaelcp94
Copy link
Contributor

Should we take advantage of extension functions to build our entities or DTO's ? i see some advantages to do that approach because we have cleaner Code, readability. On the other hand with class component we have better isolation flexibility. Do you think its worth to discuss this ?

refactor: use custom annotations for usecases and services
feat: add customer creation methods
@mmiikkkkaa
Copy link
Contributor Author

Should we take advantage of extension functions to build our entities or DTO's ? i see some advantages to do that approach because we have cleaner Code, readability. On the other hand with class component we have better isolation flexibility. Do you think its worth to discuss this ?

Its always worth discussing, but I need it a little bit more precise: in what spots would you like to use extension functions?

@mmiikkkkaa mmiikkkkaa merged commit 50b5e6c into develop Apr 5, 2024
2 checks passed
@mmiikkkkaa mmiikkkkaa deleted the 13-create-an-account branch April 5, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an account
3 participants