Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger parse level bug fix (TRACE or 3) #377

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Logger parse level bug fix (TRACE or 3) #377

merged 4 commits into from
Oct 17, 2024

Conversation

AndreiRegiani
Copy link
Contributor

@AndreiRegiani AndreiRegiani commented Oct 17, 2024

Two bugs:

  1. parse was missing to handle TRACE=3
  2. fallback value was ERROR=1 instead of INFO=2, because the enum in parse function had the wrong count

Based on the --help

    --log-level <level>   Level to log at. 0,1,2,3 (OFF,ERR,INF,TRC)
  • ./pear.dev sidecar --log-level 3 now works as expected

  • improvements to known-nodes logging (dump entire array instead of " ... 11 more", more compact output)

image

@AndreiRegiani AndreiRegiani added the bug Something isn't working label Oct 17, 2024
@rafapaezbas rafapaezbas merged commit c05c205 into main Oct 17, 2024
3 checks passed
@rafapaezbas rafapaezbas deleted the logger-level-fix branch October 17, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants