Error when encoding fixed-length buffers of incorrect size (#30)

holepunchto · Oct 18, 2024 · 9d2fd7e · 9d2fd7e
1 parent bf30820
commit 9d2fd7e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -420,6 +420,7 @@ exports.bool = {
 const fixed = exports.fixed = function fixed (n) {
   return {
     preencode (state, s) {
+      if (s.byteLength !== n) throw new Error('Incorrect buffer size')
       state.end += n
     },
     encode (state, s) {

diff --git a/test.js b/test.js
@@ -565,6 +565,19 @@ test('fixed n', function (t) {
   t.exception(() => fixed.decode(state))
 })
 
+test('error for incorrect buffer sizes when encoding fixed-length buffers', function (t) {
+  const smallbuf = b4a.from('aa', 'hex')
+  const bigBuf = b4a.from('aa'.repeat(500), 'hex')
+
+  t.exception(() => enc.encode(enc.fixed32, smallbuf), /Incorrect buffer size/)
+  t.exception(() => enc.encode(enc.fixed64, smallbuf), /Incorrect buffer size/)
+  t.exception(() => enc.encode(enc.fixed(100), smallbuf), /Incorrect buffer size/)
+
+  t.exception(() => enc.encode(enc.fixed32, bigBuf), /Incorrect buffer size/)
+  t.exception(() => enc.encode(enc.fixed64, bigBuf), /Incorrect buffer size/)
+  t.exception(() => enc.encode(enc.fixed(100), bigBuf), /Incorrect buffer size/)
+})
+
 test('array', function (t) {
   const state = enc.state()
   const arr = enc.array(enc.bool)