Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I do not use this plugin! It has only come to my attention because of the attempts by @rardcode to file an understandable issue in the correct place.
That said, the issue described in #4 (and previously in #3, linuxserver/docker-dokuwiki#58 and dokuwiki/dokuwiki#3840) seems to be caused by an excessive number of PHP warnings which in turn are triggered in
DokuWiki-WikiFormatStyling-Plugin/syntax/nwtag.php
Line 48 in 7189d24
$data
isnull
in some cases.I do not have enough experience with the DokuWiki plugin API to really tell but I think this might be caused by the
handle()
method not always having a defined return value. This is just a guess though. This PR attempts to fix the results of this by checking$data
before use in therender()
method.The same thing seems to be happening in
DokuWiki-WikiFormatStyling-Plugin/syntax/pcnt.php
Line 48 in 7189d24
Please note that this is completely untested. So please check whether this works before merging or implement a better fix if possible.
HTH
fiwswe