Merge pull request #34 from ho-nl/feature/fix-required-delimiter

Delimiter should be an optional parameter to keep it backward compati…
ho-nl · Oct 19, 2022 · d6a616c · d6a616c
2 parents d8dad39 + a826216
commit d6a616c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Streamer/FileCsv.php b/src/Streamer/FileCsv.php
@@ -34,7 +34,7 @@ class FileCsv
     /** @var Log $log */
     private $log;
 
-    /** @var string $delimiter */
+    /** @var ?string $delimiter */
     private $delimiter;
 
     /** @var array $headers */
@@ -57,7 +57,7 @@ public function __construct(
         DirectoryList $directoryList,
         string $requestFile,
         Log $log,
-        string $delimiter,
+        ?string $delimiter = null,
         array $headers = [],
         string $escapeCharacter = ''
     ) {

diff --git a/src/Streamer/HttpCsv.php b/src/Streamer/HttpCsv.php
@@ -70,7 +70,7 @@ class HttpCsv
     private $log;
 
     /**
-     * @var string
+     * @var ?string
      */
     private $delimiter;
 
@@ -94,7 +94,7 @@ public function __construct(
         ConsoleOutput $consoleOutput,
         string $requestUrl,
         Log $log,
-        string $delimiter,
+        ?string $delimiter = null,
         string $encodingConversion = '',
         string $requestMethod = 'GET',
         array $requestOptions = [],