ALS-7014: Implement signed URL functionality for data exports #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke-Sikina
reviewed
Sep 3, 2024
Comment on lines
247
to
254
| // This happens sometimes when users immediately request the status for a query | ||
| // before it can be initialized. We wait a bit and try again before throwing an | ||
| // error. | ||
| try { | ||
| Thread.sleep(100); | ||
| } catch (InterruptedException e) { | ||
| return ResponseEntity.status(500).build(); | ||
| } |
There was a problem hiding this comment.
What does waiting do? Are you debouncing a button on the backend?
There was a problem hiding this comment.
This is boilerplate code copied from the /result endpoint. But true, it should not be needed, no one should call this endpoint until the status returns SUCCESS which would mean the query exists
Luke-Sikina
reviewed
Sep 3, 2024
| .contentType(MediaType.APPLICATION_JSON) | ||
| .body(new SignedUrlResponse(presignedGetUrl)); | ||
| } else { | ||
| return ResponseEntity.status(400).body("Status : " + result.getStatus().name()); |
There was a problem hiding this comment.
Is 400 a fair response code for pending statuses? Maybe 202?
There was a problem hiding this comment.
Yes, I think it is appropriate. Or at least consistent with the current workflow of the /result endpoint. The front end polls /status until it is SUCCESS, then calls this endpoint for a signed url, or /result for the document itself
Luke-Sikina
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.