Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase two redo #167

Draft
wants to merge 152 commits into
base: main
Choose a base branch
from
Draft

Phase two redo #167

wants to merge 152 commits into from

Conversation

rrrragas
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #151 #153

Test URLs:

Please note, for testing urls, make sure to include the lighthouse=on URL parameter to bypass the Modal, and get the correct PSI Score.

Before: https://main--takeda-ihs--hlxsites.hlx.page/?=lighthouse=on
After: https://phase-two-redo--takeda-ihs--hlxsites.hlx.page/?=lighthouse=on

Copy link

aem-code-sync bot commented Jan 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch

Note: PSI checks are disabled due to site authentication. Please utilize your org/client side GHA PSI implementation

Commits

Copy link

aem-code-sync bot commented Jan 25, 2024

Skipping PSI check because site is authenticated.

Copy link

aem-code-sync bot commented Jan 29, 2024

Skipping PSI check because site is authenticated.

development seems to work
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo March 5, 2024 14:45 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo March 5, 2024 17:42 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo March 5, 2024 19:53 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo March 5, 2024 20:08 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo March 5, 2024 21:10 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo March 7, 2024 21:08 Inactive
hidden fields take up white space so setting to display none
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo May 20, 2024 15:02 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo May 28, 2024 13:01 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to phase-two-redo May 28, 2024 13:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phase 1B New Style for Disclaimer Modal.....
3 participants