generated from adobe/aem-boilerplate
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase two redo #167
Draft
rrrragas
wants to merge
152
commits into
main
Choose a base branch
from
phase-two-redo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Phase two redo #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lots of display layer changes
white bg was showing under contact us banner
removing top padding on sections its crating white space
center align content section titles
The default cards with a border per the new designs
just removed the border.
Mostly aligning floating image section to the new designs and also some tweaks to the cards....
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Skipping PSI check because site is authenticated. |
Skipping PSI check because site is authenticated. |
development seems to work
hidden fields take up white space so setting to display none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #151 #153
Test URLs:
Please note, for testing urls, make sure to include the
lighthouse=on
URL parameter to bypass the Modal, and get the correct PSI Score.Before: https://main--takeda-ihs--hlxsites.hlx.page/?=lighthouse=on
After: https://phase-two-redo--takeda-ihs--hlxsites.hlx.page/?=lighthouse=on