-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoblock image followed by cursive text into image-collage with 1 col #86
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there might be an edge-case,
https://issue-85--sunstar--hlxsites.hlx.page/_drafts/dbute/image-caption
For the first image, I pressed enter
after the image in order to add the text
For the second image I pressed enter + shift
after the image, which inserts a <br>
element, and that seems to break the caption, I think it's good that you can control the autoblocking, but I'm not sure this was intended/if the authoring experience to "disable" auto-captioning is the best
Also, as a side-effect, the image seems to get smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure feel free to extend it! |
Sure, I'll do that as part of #87 after you merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my concerns have been addressed, will extend this for my use-case after merge
When an image is followed by cursive text, this combination with be auto-blocked into an image-collage with 1 column for an Image with a caption.
The caption can either follow the image directly:
or it can follow the image on the next line:
The result will be an
image-collage
block with theboxy-col-1
styleContributes to #85
Test URLs (see bottom for example):