Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tabs block, added transition #83

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Added tabs block, added transition #83

merged 3 commits into from
Oct 2, 2023

Conversation

dnbute
Copy link

@dnbute dnbute commented Oct 2, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #84

  • Added tabs block
  • Added fade transition when switching tabs, implemented for tabs and hero-horizontal-tabs
  • Small change to network-item due to an icon being shorter now
  • Updated spaced style to not change heading color

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 2, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 2, 2023

Page Scores Audits Google
/_drafts/dbute/tabs/tabs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dnbute dnbute added this to the Milestone-3 milestone Oct 2, 2023
Copy link

@bosschaert bosschaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 2, 2023

Page Scores Audits Google
/_drafts/dbute/tabs/tabs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Oct 2, 2023

Page Scores Audits Google
/_drafts/dbute/tabs/tabs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🔸 1 visual difference detected

  • /sidekick/blocks/sections (main vs branch)
    Expected an image 1312px by 6512px, received 1312px by 6295px. 320968 pixels (ratio 0.04 of all image pixels) are different.

The diff images are attached in the artifact

@dnbute
Copy link
Author

dnbute commented Oct 2, 2023

🔸 1 visual difference detected

  • /sidekick/blocks/sections (main vs branch)Expected an image 1312px by 6512px, received 1312px by 6295px. 320968 pixels (ratio 0.04 of all image pixels) are different.

The diff images are attached in the artifact

This is due to adding new styles to the library

@dnbute dnbute merged commit 560e7cb into main Oct 2, 2023
4 checks passed
@dnbute dnbute deleted the tabs branch October 2, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tabs for business performance page
2 participants