News cards feed #82

sdmcraft · 2023-10-01T18:30:36Z

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fixes #9

Test URLs:

Original: https://www.sunstar.com/
Before: https://i-9c--sunstar--hlxsites.hlx.live/_drafts/satyam/
After: https://news-cards--sunstar--hlxsites.hlx.live/_drafts/satyam/
If you are adding a new block or a variation to an existing block, please fill below:

Block library path: https://--sunstar--hlxsites.hlx.page/tools/sidekick/library.html?plugin=blocks&path=/sidekick/blocks/&index=0

aem-code-sync · 2023-10-01T18:30:38Z

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

Re-run PSI Checks

aem-code-sync · 2023-10-01T18:30:59Z

Page	Scores	Audits	Google
/_drafts/satyam		Lighthouse returned error: ERRORED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Status code: 404)

github-actions · 2023-10-01T18:32:57Z

🔸 4 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3933px, received 1280px by 3441px. 2988919 pixels (ratio 0.60 of all image pixels) are different.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 5021px, received 1312px by 5003px.
/sidekick/blocks/feed (main vs branch)
9659 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

aem-code-sync · 2023-10-01T18:33:02Z

Page	Scores	Audits	Google
/_drafts/satyam/

aem-code-sync · 2023-10-01T18:51:57Z

Page	Scores	Audits	Google
/_drafts/satyam/

github-actions · 2023-10-01T18:53:53Z

🔸 4 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3933px, received 1280px by 3441px. 2988919 pixels (ratio 0.60 of all image pixels) are different.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 5021px, received 1312px by 5003px.
/sidekick/blocks/feed (main vs branch)
9659 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

scripts/scripts.js

dnbute

Is the fact that the cards are not clickable expected for this pr?

aem-code-sync · 2023-10-03T08:12:34Z

Page	Scores	Audits	Google
/_drafts/satyam/

github-actions · 2023-10-03T08:14:15Z

🔸 5 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3933px, received 1280px by 3441px. 2988919 pixels (ratio 0.60 of all image pixels) are different.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 6313px, received 1312px by 6512px. 320867 pixels (ratio 0.04 of all image pixels) are different.
/sidekick/blocks/hero-banner (main vs branch)
Expected an image 1280px by 720px, received 1280px by 820px. 522039 pixels (ratio 0.50 of all image pixels) are different.
/sidekick/blocks/feed (main vs branch)
9659 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

aem-code-sync · 2023-10-03T08:29:05Z

Page	Scores	Audits	Google
/_drafts/satyam/

sdmcraft · 2023-10-03T08:29:33Z

Is the fact that the cards are not clickable expected for this pr?

Fixed.

github-actions · 2023-10-03T08:30:25Z

🔸 5 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3933px, received 1280px by 3441px. 2988919 pixels (ratio 0.60 of all image pixels) are different.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 6313px, received 1312px by 6512px. 320867 pixels (ratio 0.04 of all image pixels) are different.
/sidekick/blocks/hero-banner (main vs branch)
Expected an image 1280px by 720px, received 1280px by 820px. 522039 pixels (ratio 0.50 of all image pixels) are different.
/sidekick/blocks/feed (main vs branch)
9570 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

…cards

aem-code-sync · 2023-10-04T07:19:10Z

Page	Scores	Audits	Google
/_drafts/satyam/

github-actions · 2023-10-04T07:20:46Z

🔸 4 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3312px, received 1280px by 2819px. 2036368 pixels (ratio 0.49 of all image pixels) are different.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 6530px, received 1312px by 6512px.
/sidekick/blocks/feed (main vs branch)
9570 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

…cards

aem-code-sync · 2023-10-04T07:46:05Z

Page	Scores	Audits	Google
/_drafts/satyam/

github-actions · 2023-10-04T07:47:49Z

🔸 3 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3312px, received 1280px by 2819px. 2036368 pixels (ratio 0.49 of all image pixels) are different.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 6530px, received 1312px by 6512px.

The diff images are attached in the artifact

aem-code-sync · 2023-10-04T09:36:56Z

Page	Scores	Audits	Google
/_drafts/satyam/

github-actions · 2023-10-04T09:38:28Z

🔸 2 visual differences detected

/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 6530px, received 1312px by 6512px.

The diff images are attached in the artifact

sdmcraft · 2023-10-04T09:38:52Z

Is the fact that the cards are not clickable expected for this pr?

Fixed.

sdmcraft · 2023-10-04T09:39:31Z

🔸 2 visual differences detected

/sidekick/blocks/cards (main vs branch)Expected an image 1280px by 1175px, received 1280px by 1011px. 39818 pixels (ratio 0.03 of all image pixels) are different.

/sidekick/blocks/sections (main vs branch)Expected an image 1312px by 6530px, received 1312px by 6512px.

The diff images are attached in the artifact

Both of these are expected since this PR proposes changes in cards styling.

hparwani2 · 2023-10-04T13:14:29Z

blocks/cards/cards.css

@@ -93,11 +99,9 @@ main .block.cards {
 }

 .cards .cards-card-image {
+  height: 155px;


can we use rem here?

aem-code-sync · 2023-10-04T13:30:55Z

Page	Scores	Audits	Google
/_drafts/satyam/

github-actions · 2023-10-04T13:32:52Z

🔸 10 visual differences detected

/career/yuya-yoshisue (main vs branch)
Expected an image 1280px by 3933px, received 1280px by 3981px. 325689 pixels (ratio 0.07 of all image pixels) are different.
/sidekick/blocks/hero (main vs branch)
Expected an image 1441px by 4004px, received 1441px by 4052px.
/sidekick/blocks/collage (main vs branch)
Expected an image 1280px by 5160px, received 1280px by 5206px.
/sidekick/blocks/columns (main vs branch)
Expected an image 1280px by 7092px, received 1280px by 7070px.
/sidekick/blocks/cards (main vs branch)
Expected an image 1280px by 1155px, received 1280px by 1011px. 39706 pixels (ratio 0.03 of all image pixels) are different.
/sidekick/blocks/text-image (main vs branch)
Expected an image 1280px by 4107px, received 1280px by 4108px.
/sidekick/blocks/carousel (main vs branch)
Expected an image 1280px by 1306px, received 1280px by 1354px. 146329 pixels (ratio 0.09 of all image pixels) are different.
/sidekick/blocks/sections (main vs branch)
Expected an image 1312px by 6520px, received 1312px by 6536px. 264673 pixels (ratio 0.04 of all image pixels) are different.
/sidekick/blocks/career-apply (main vs branch)
40960 pixels (ratio 0.05 of all image pixels) are different.
/sidekick/blocks/feed (main vs branch)
11880 pixels (ratio 0.02 of all image pixels) are different.

The diff images are attached in the artifact

Satya Deep Maheshwari added 19 commits September 25, 2023 15:53

Add feed block

a734f5d

Added code comments

6ebde33

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

e24aad6

Incorporated review feedback

05d83f7

Commenting out failing test temporarily

1695891

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

9a43a07

Removing UTs. To be taken up separately

9aee95a

wip

1967da2

Adjust query criteria

e0bea29

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

6a3d0ab

Add tests

5f945c7

Removed test code

1e574df

Remove unintentional changes

e9a1448

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

f142d26

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

2e3f5e7

Omit unintentional changes

c508327

Added code comments

0a00c21

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

73af8fa

New cards feed

cb9c016

sdmcraft changed the title ~~New cards feed~~ News cards feed Oct 1, 2023

Fix failing UT

0b8e8ea

sdmcraft marked this pull request as draft October 1, 2023 18:52

jindaliiita reviewed Oct 2, 2023

View reviewed changes

scripts/scripts.js Outdated Show resolved Hide resolved

dnbute reviewed Oct 2, 2023

View reviewed changes

Incorporate revew feedback

6061af7

Satya Deep Maheshwari added 3 commits October 3, 2023 14:03

Merge branch 'main' of https://github.com/hlxsites/sunstar into i-9c

b1dda0c

Merge branch 'i-9c' of https://github.com/hlxsites/sunstar into news-…

ee6d2cc

…cards

Fix UTs

206421a

Base automatically changed from i-9c to main October 4, 2023 07:34

Merge branch 'main' of https://github.com/hlxsites/sunstar into news-…

8ec23ca

…cards

Use temp index till indexing is fixed

8722810

sdmcraft marked this pull request as ready for review October 4, 2023 09:37

Styling fixes

156831f

jindaliiita approved these changes Oct 4, 2023

View reviewed changes

hparwani2 reviewed Oct 4, 2023

View reviewed changes

blocks/cards/cards.css

@@ -93,11 +99,9 @@ main .block.cards {

}

.cards .cards-card-image {

height: 155px;

Copy link

hparwani2 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use rem here?

Fix UTs

eb993e3

sdmcraft merged commit af72966 into main Oct 4, 2023
4 checks passed

sdmcraft deleted the news-cards branch October 4, 2023 13:36

sdmcraft added this to the Milestone-3 milestone Oct 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

News cards feed #82

News cards feed #82

sdmcraft commented Oct 1, 2023 •

edited

Loading

aem-code-sync bot commented Oct 1, 2023 •

edited

Loading

aem-code-sync bot commented Oct 1, 2023

github-actions bot commented Oct 1, 2023

aem-code-sync bot commented Oct 1, 2023

aem-code-sync bot commented Oct 1, 2023

github-actions bot commented Oct 1, 2023

dnbute left a comment

aem-code-sync bot commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

aem-code-sync bot commented Oct 3, 2023

sdmcraft commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

sdmcraft commented Oct 4, 2023

sdmcraft commented Oct 4, 2023

🔸 2 visual differences detected

hparwani2 Oct 4, 2023

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

News cards feed #82

News cards feed #82

Conversation

sdmcraft commented Oct 1, 2023 • edited Loading

aem-code-sync bot commented Oct 1, 2023 • edited Loading

aem-code-sync bot commented Oct 1, 2023

github-actions bot commented Oct 1, 2023

🔸 4 visual differences detected

aem-code-sync bot commented Oct 1, 2023

aem-code-sync bot commented Oct 1, 2023

github-actions bot commented Oct 1, 2023

🔸 4 visual differences detected

dnbute left a comment

Choose a reason for hiding this comment

aem-code-sync bot commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

🔸 5 visual differences detected

aem-code-sync bot commented Oct 3, 2023

sdmcraft commented Oct 3, 2023

github-actions bot commented Oct 3, 2023

🔸 5 visual differences detected

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

🔸 4 visual differences detected

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

🔸 3 visual differences detected

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

🔸 2 visual differences detected

sdmcraft commented Oct 4, 2023

sdmcraft commented Oct 4, 2023

🔸 2 visual differences detected

hparwani2 Oct 4, 2023

Choose a reason for hiding this comment

aem-code-sync bot commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

🔸 10 visual differences detected

sdmcraft commented Oct 1, 2023 •

edited

Loading

aem-code-sync bot commented Oct 1, 2023 •

edited

Loading