Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template to use .live URLs for more consistent LHS #79

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

bosschaert
Copy link

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert bosschaert marked this pull request as draft September 28, 2023 18:24
@bosschaert bosschaert marked this pull request as ready for review September 28, 2023 18:26
@sdmcraft sdmcraft merged commit b27b371 into main Sep 29, 2023
4 checks passed
@jindaliiita
Copy link

@sdmcraft @bosschaert I doubt if this is right to change the default template to .live.
@sdmcraft Yesterday, you mentioned that .page is used to determine any potential (LHS) impact before publishing it to .live.
From our development perspective, both .live and .page are fine. However, after the website went live, the meanings of .live and .page will be different.

@bosschaert
Copy link
Author

@jindaliiita I'm not sure I fully follow your comment 😄

The LHS is largely dependent on the JavaScript code and should really not be much influenced by the content. An author should always get a great LHS whatever changes are made in the content. The JS should take care if this. So the publishing of a page (to .live) should not have much of an impact on the LHS.

On the other hand, for the computation of the LHS in PRs the .page pages have shown to be unreliable. This is probably relating to the caching on the CDN level which isn't really there for the .page files. So to get a more realistic (as this is what the users would experience) and consistent LHS the move to .live pages makes sense to me...

@jindaliiita
Copy link

@jindaliiita I'm not sure I fully follow your comment 😄

The LHS is largely dependent on the JavaScript code and should really not be much influenced by the content. An author should always get a great LHS whatever changes are made in the content. The JS should take care if this. So the publishing of a page (to .live) should not have much of an impact on the LHS.

On the other hand, for the computation of the LHS in PRs the .page pages have shown to be unreliable. This is probably relating to the caching on the CDN level which isn't really there for the .page files. So to get a more realistic (as this is what the users would experience) and consistent LHS the move to .live pages makes sense to me...

@bosschaert You have completely understood my comment, and I also understand your point that this will not cause any problems.
Thanks for explaining it in detail. I forgot that LHS is mostly dependent on the JS code 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants