Rename career-hero to hero-career to follow hero block guidelines #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a layout issue with this block
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
🔸 1 visual difference detected
The diff images are attached in the artifact |
|
|
|
🔸 1 visual difference detected
The diff images are attached in the artifact |
sdmcraft
approved these changes
Sep 29, 2023
jindaliiita
reviewed
Sep 29, 2023
| heroRight.classList.add('hero-career-right'); | ||
| heroDiv.appendChild(heroRight); | ||
| addTextEl('blockquote', cfg.quote, heroRight, 'hero-career-quote'); | ||
| addTextEl('h6', 'Career background', heroRight, 'hero-career-careerbgtitle'); // TODO i18n |
There was a problem hiding this comment.
We will have to have a separate effort (probably fairly small) to make these pages work with Japanese. This issue will become evident then.
|
bosschaert
force-pushed
the
issue-15-2
branch
from
0cf0e45 to
aef9361
Compare
|
🔸 2 visual differences detected
The diff images are attached in the artifact |
🔸 2 visual differences detected
The diff images are attached in the artifact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a layout problem with the hero block for career testimonials
Fixes #15
Test URLs: