Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small column block (project and grant page) #68

Closed
wants to merge 7 commits into from

Conversation

RitwikSrivastava
Copy link

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #<52

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 26, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 26, 2023

Page Scores Audits Google
/_drafts/ritsriva/project Lighthouse returned error: FAILED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: net::ERR_TIMED_OUT) PSI

1 similar comment
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 26, 2023

Page Scores Audits Google
/_drafts/ritsriva/project Lighthouse returned error: FAILED_DOCUMENT_REQUEST. Lighthouse was unable to reliably load the page you requested. Make sure you are testing the correct URL and that the server is properly responding to all requests. (Details: net::ERR_TIMED_OUT) PSI

.columns-small h2,
.columns-small:not(.no-buttons) h3,
.columns-small:not(.no-buttons) h4 {
color: #3C4650;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a colour variable in styles.css with this value that you can reference here.

@sdmcraft
Copy link

@RitwikSrivastava , please create a PR with a branch from the same repo instead of your fork.

@RitwikSrivastava
Copy link
Author

raised a new PR. #74 closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants