-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to index for career testimonials #66
Conversation
Add quote, image and jobtitle
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
image: | ||
select: head > meta[property="og:image"] | ||
value: attribute(el, "content") | ||
career-quote: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the need of this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need the image. It's stored with the normal metadata as it's also the main image of the page.
The default indexing does this already, but I think you have to list it explicitly if you have a helix-query.yaml file (at least it didn't work for me when I tried it without).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was talking about career-quote and career-jobtitle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are needed on the career-carousel which is displayed on a number of pages. This is implementing a suggestion from @sdmcraft to put this info in the index so the carousel can obtain its info from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, Thanks
Add quote, image and jobtitle
New approach to what was attempted earlier in #54
Contributes to #17
Test URLs: