Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to index for career testimonials #66

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

bosschaert
Copy link

@bosschaert bosschaert commented Sep 25, 2023

Add quote, image and jobtitle

New approach to what was attempted earlier in #54

Contributes to #17

Test URLs:

  • If you are adding a new block or a variation to an existing block, has it been added in the block-inventory ?

Add quote, image and jobtitle
@aem-code-sync
Copy link

aem-code-sync bot commented Sep 25, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 25, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert bosschaert requested a review from sdmcraft September 25, 2023 15:32
image:
select: head > meta[property="og:image"]
value: attribute(el, "content")
career-quote:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the need of this ?

Copy link
Author

@bosschaert bosschaert Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need the image. It's stored with the normal metadata as it's also the main image of the page.

The default indexing does this already, but I think you have to list it explicitly if you have a helix-query.yaml file (at least it didn't work for me when I tried it without).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was talking about career-quote and career-jobtitle

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are needed on the career-carousel which is displayed on a number of pages. This is implementing a suggestion from @sdmcraft to put this info in the index so the carousel can obtain its info from there.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, Thanks

@bosschaert bosschaert merged commit 60bbd48 into main Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants